On Wed, Sep 05, 2012 at 08:03:20PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:52 Wed 05 Sep , Jan Luebbe wrote: > > Signed-off-by: Jan Luebbe <jlu@xxxxxxxxxxxxxx> > Again NACK > > drop the struct XXXX on hte reg I also don't like it, but let's not be religious about it. Wolfgang currently forces all people to use structs for registers. Forcing exactly the opposite is counterproductive I think. The original drivers uses the structs and at some point it can be useful to compare to this driver. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
