2012/9/6 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>: > Hi Franck, > > On Wed, Sep 05, 2012 at 10:37:26PM +0200, Franck Jullien wrote: >> In a previous patch, Sascha needed to add __ashrdi3 and then linked to >> libgcc. This patch add the ashrdi3 function in the arch/openrisc/lib >> directory and remove the libgcc link. > > Does this fix any regressions or is it just a do-the-right-thing patch? > No, it doesn't fix anything. I just did the same thing I did for others libgcc functions. >> >> Signed-off-by: Franck Jullien <franck.jullien@xxxxxxxxx> >> --- >> arch/openrisc/Makefile | 4 +- >> arch/openrisc/lib/Makefile | 1 + >> arch/openrisc/lib/ashrdi3.S | 59 +++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 62 insertions(+), 2 deletions(-) >> create mode 100644 arch/openrisc/lib/ashrdi3.S >> >> diff --git a/arch/openrisc/Makefile b/arch/openrisc/Makefile >> index 1f4b175..9e88a51 100644 >> --- a/arch/openrisc/Makefile >> +++ b/arch/openrisc/Makefile >> @@ -1,6 +1,6 @@ >> CPPFLAGS += -D__OR1K__ -ffixed-r10 -mhard-mul -mhard-div >> >> -LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name) >> +#LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name) > > Can we remove the line instead? I wanted to keep it in case we have the problem again (need to link to libgcc)..... > >> >> board-$(CONFIG_GENERIC) := generic >> >> @@ -20,6 +20,6 @@ common-y += $(BOARD) >> common-y += arch/openrisc/lib/ >> common-y += arch/openrisc/cpu/ >> >> -common-y += $(LIBGCC) >> +#common-y += $(LIBGCC) > > ditto. But I could remove it of course. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
