On Fri, Jul 27, 2012 at 01:03:30PM +0200, Jan Weitzel wrote:
> Am Freitag, den 27.07.2012, 10:41 +0200 schrieb Uwe Kleine-König:
> > A barebox image generated from pcm043_defconfig doesn't fit into the
> > 0x40000 byte sized self partition as of
> >
> > v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)
> >
> > .
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > arch/arm/boards/pcm043/pcm043.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> > index b1bf8ef..7ccd973 100644
> > --- a/arch/arm/boards/pcm043/pcm043.c
> > +++ b/arch/arm/boards/pcm043/pcm043.c
> > @@ -153,15 +153,15 @@ static int imx35_devices_init(void)
> > if ((reg & 0xc00) == 0x800) { /* reset mode: external boot */
> > switch ( (reg >> 25) & 0x3) {
> > case 0x01: /* NAND is the source */
> > - devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
> > + devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
> What do you think about SZ_128K + SZ_256K ? Maybe SZ_512K is even
> better.
I don't like SZ_128K + SZ_256K, which in my eyes is more ugly than a hex
constant. And using 512 kiB seems unnecessary to me. I'd like to stay
with 0x60000.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
