> -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@xxxxxxxxxxxx] > Sent: Sunday, 29 July 2012 8:01 PM > To: Marc Reilly > Cc: barebox@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 6/7] nand: Prevent drivers setting > NAND_USE_FLASH_BBT if BBT config not enabled. > > On 17:41 Sun 29 Jul , Marc Reilly wrote: > > This prevents drivers from setting the options flags to use the flash > > bab block table when the BBT is not enabled in config. > > > > Signed-off-by: Marc Reilly <marc@xxxxxxxxxxxxxxx> > > --- > > drivers/mtd/nand/atmel_nand.c | 2 +- > > drivers/mtd/nand/nand_imx.c | 2 +- > > drivers/mtd/nand/nand_s3c24xx.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mtd/nand/atmel_nand.c > > b/drivers/mtd/nand/atmel_nand.c index 96624a1..cc62df9 100644 > > --- a/drivers/mtd/nand/atmel_nand.c > > +++ b/drivers/mtd/nand/atmel_nand.c > > @@ -407,7 +407,7 @@ static int __init atmel_nand_probe(struct device_d > *dev) > > } > > } > > > > - if (host->board->on_flash_bbt) { > > + if (IS_ENABLED(CONFIG_NAND_BBT) && host->board- > >on_flash_bbt) { > > printk(KERN_INFO "atmel_nand: Use On Flash BBT\n"); > > nand_chip->options |= NAND_USE_FLASH_BBT; > driver pass this info to the nand framework which is supposed to handle this > by itself Ok, cool. Assuming the nand framework handles this then please drop this patch. Cheers, Narc _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox