On Fri, 10 Feb 2012, Sascha Hauer wrote: > On Fri, Feb 10, 2012 at 09:39:10AM -0500, Robert P. J. Day wrote: > > > > thoughts on the following patch? it's certainly not the final > > result, but it at least *starts* the process of properly recognizing > > newer pandaboards, using code taking very close to verbatim out of > > u-boot. > > > > it's been compile-tested and appears to still work on all boards it > > did before. i'll do a bit more testing to make sure of that, but is > > there any philosophical objection to the following as a single patch > > submission? > > Nope, looks good, except for the whitespace damage between here > > > + case MIDR_CORTEX_A9_R2P10: > > + switch (readl(CONTROL_ID_CODE)) { > > + case OMAP4460_CONTROL_ID_CODE_ES1_1: > > + return OMAP4460_ES1_1; > > + break; > > + case OMAP4460_CONTROL_ID_CODE_ES1_0: > > + default: > > + return OMAP4460_ES1_0; > > + break; > > + } > > + break; > > + default: > > + return OMAP4430_SILICON_ID_INVALID; > > + break; > > } > > and here. ok, i'll go back and fix and resubmit. rday _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox