Most members of the S3Cxxxx family share similar timer units. But they are not really register compatible. To reflect this, use a separate name space for the S3C family. Signed-off-by: Juergen Beisert <jbe@xxxxxxxxxxxxxx> --- arch/arm/mach-samsung/include/mach/s3c-iomap.h | 20 +------------- arch/arm/mach-samsung/s3c-timer.c | 33 ++++++++++++++++++------ 2 files changed, 26 insertions(+), 27 deletions(-) diff --git a/arch/arm/mach-samsung/include/mach/s3c-iomap.h b/arch/arm/mach-samsung/include/mach/s3c-iomap.h index 7cedf6a..807660a 100644 --- a/arch/arm/mach-samsung/include/mach/s3c-iomap.h +++ b/arch/arm/mach-samsung/include/mach/s3c-iomap.h @@ -29,7 +29,7 @@ #define S3C2410_LCD_BASE 0x4D000000 #define S3C24X0_NAND_BASE 0x4E000000 #define S3C24X0_UART_BASE 0x50000000 -#define S3C24X0_TIMER_BASE 0x51000000 +#define S3C_TIMER_BASE 0x51000000 #define S3C2410_USB_DEVICE_BASE 0x52000140 #define S3C24X0_WATCHDOG_BASE 0x53000000 #define S3C2410_I2C_BASE 0x54000000 @@ -40,24 +40,6 @@ #define S3C2410_SPI_BASE 0x59000000 #define S3C2410_SDI_BASE 0x5A000000 -/* Timer (direct access) */ -#define TCFG0 (S3C24X0_TIMER_BASE + 0x00) -#define TCFG1 (S3C24X0_TIMER_BASE + 0x04) -#define TCON (S3C24X0_TIMER_BASE + 0x08) -#define TCNTB0 (S3C24X0_TIMER_BASE + 0x0c) -#define TCMPB0 (S3C24X0_TIMER_BASE + 0x10) -#define TCNTO0 (S3C24X0_TIMER_BASE + 0x14) -#define TCNTB1 (S3C24X0_TIMER_BASE + 0x18) -#define TCMPB1 (S3C24X0_TIMER_BASE + 0x1c) -#define TCNTO1 (S3C24X0_TIMER_BASE + 0x20) -#define TCNTB2 (S3C24X0_TIMER_BASE + 0x24) -#define TCMPB2 (S3C24X0_TIMER_BASE + 0x28) -#define TCNTO2 (S3C24X0_TIMER_BASE + 0x2c) -#define TCNTB3 (S3C24X0_TIMER_BASE + 0x30) -#define TCMPB3 (S3C24X0_TIMER_BASE + 0x34) -#define TCNTO3 (S3C24X0_TIMER_BASE + 0x38) -#define TCNTB4 (S3C24X0_TIMER_BASE + 0x3c) -#define TCNTO4 (S3C24X0_TIMER_BASE + 0x40) /* Watchdog (direct access) */ #define WTCON (S3C24X0_WATCHDOG_BASE) diff --git a/arch/arm/mach-samsung/s3c-timer.c b/arch/arm/mach-samsung/s3c-timer.c index 2b0b38a..d9dae55 100644 --- a/arch/arm/mach-samsung/s3c-timer.c +++ b/arch/arm/mach-samsung/s3c-timer.c @@ -21,10 +21,27 @@ #include <mach/s3c-iomap.h> #include <mach/s3c-generic.h> +#define S3C_TCFG0 (S3C_TIMER_BASE + 0x00) +# define S3C_TCFG0_T4MASK 0xff00 +# define S3C_TCFG0_SET_PSCL234(x) ((x) << 8) +# define S3C_TCFG0_GET_PSCL234(x) (((x) >> 8) & 0xff) +#define S3C_TCFG1 (S3C_TIMER_BASE + 0x04) +# define S3C_TCFG1_T4MASK 0xf0000 +# define S3C_TCFG1_SET_T4MUX(x) ((x) << 16) +# define S3C_TCFG1_GET_T4MUX(x) (((x) >> 16) & 0xf) +#define S3C_TCON (S3C_TIMER_BASE + 0x08) +# define S3C_TCON_T4MASK (7 << 20) +# define S3C_TCON_T4START (1 << 20) +# define S3C_TCON_T4MANUALUPD (1 << 21) +# define S3C_TCON_T4RELOAD (1 <<22) +#define S3C_TCNTB4 (S3C_TIMER_BASE + 0x3c) +#define S3C_TCNTO4 (S3C_TIMER_BASE + 0x40) + + static uint64_t s3c24xx_clocksource_read(void) { /* note: its a down counter */ - return 0xFFFF - readw(TCNTO4); + return 0xFFFF - readw(S3C_TCNTO4); } static struct clocksource cs = { @@ -37,15 +54,15 @@ static int clocksource_init(void) { uint32_t p_clk = s3c_get_pclk(); - writel(0x00000000, TCON); /* stop all timers */ - writel(0x00ffffff, TCFG0); /* PCLK / (255 + 1) for timer 4 */ - writel(0x00030000, TCFG1); /* /16 */ + writel(0x00000000, S3C_TCON); /* stop all timers */ + writel(0x00ffffff, S3C_TCFG0); /* PCLK / (255 + 1) for timer 4 */ + writel(0x00030000, S3C_TCFG1); /* /16 */ - writew(0xffff, TCNTB4); /* reload value is TOP */ + writew(0xffff, S3C_TCNTB4); /* reload value is TOP */ - writel(0x00600000, TCON); /* force a first reload */ - writel(0x00400000, TCON); - writel(0x00500000, TCON); /* enable timer 4 with auto reload */ + writel(0x00600000, S3C_TCON); /* force a first reload */ + writel(0x00400000, S3C_TCON); + writel(0x00500000, S3C_TCON); /* enable timer 4 with auto reload */ cs.mult = clocksource_hz2mult(p_clk / ((255 + 1) * 16), cs.shift); init_clock(&cs); -- 1.7.7.3 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox