Re: [PATCH 7/7] nand-bb: implement lseek in readonly mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes:

> This one should work like expected:
>
> 	while (raw_pos < bb->raw_size) {
> 		off_t now = min(offset, bb->info.erasesize);
>
> 		ret = cdev_ioctl(bb->cdev_parent, MEMGETBADBLOCK, (void *)raw_pos);
> 		if (ret < 0)
> 			return ret;
> 		if (!ret) {
> 			offset -= now;
> 			raw_pos += now;
> 		} else {
> 			raw_pos += bb->info.erasesize
> 		}
> 		if (!offset) {
> 			bb->offset = raw_pos;
> 			return __offset;
> 		}
> 	}
Yup, looks good.
If you wish, you can add my :
Reviewed-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Cheers.

--
Robert

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux