Re: [PATCH 9/9] arm/mach-pxa: add mioa701 board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> writes:

> On 11/24/2011 04:02 AM, Robert Jarzmik wrote:
>> Add Mitac MioA701 board initial support.
>> The support only provides basic boot and a console over USB
>> (serial gadget).
>
> Please remove the address of the FSF in the header of the files, please
> fix you (C), we don't have 2012 yet :)
OK :)

>> diff --git a/Makefile b/Makefile
>> index 1d1e50d..7e94d37 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -163,8 +163,8 @@ export srctree objtree VPATH
>>  # Alternatively CROSS_COMPILE can be set in the environment.
>>  # Default value for CROSS_COMPILE is not to prefix executables
>>  
>> -ARCH            ?= sandbox
>> -CROSS_COMPILE   ?=
>> +ARCH            ?= arm
>> +CROSS_COMPILE   ?= /home/rj/mio_linux/arm-2007q1/bin/arm-none-eabi-
>
> Please remove that hunk :)
Urgh, the little sneaky one.

...zip...
All following remarks will be taken into account for v2.

Thanks for the review.

-- 
Robert

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux