Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> writes: >> +#define BAREBOX_START 0x00000 >> +#define BAREBOX_LENGTH 0x34000 >> +#define NPE_A_START (BAREBOX_START + BAREBOX_LENGTH) >> +#define NPE_A_LENGTH 0x05000 >> +#define NPE_B_START (NPE_A_START + NPE_A_LENGTH) >> +#define NPE_B_LENGTH 0x03000 >> +#define NPE_C_START (NPE_B_START + NPE_B_LENGTH) >> +#define NPE_C_LENGTH 0x04000 >> +#define NPE_ENV0_START (NPE_C_START + NPE_C_LENGTH) >> +#define NPE_ENV0_LENGTH 0x20000 > > btw you have a lots of whitespace please use tab for indent Well, I try to use tabs for syntactic indentation exclusively. I admit I haven't checked the patches for this, and some spaces could have slipped through e.g. copy+paste. Will check. OTOH I use spaces for visual alignment (as shown above) and I consider it the right thing. It makes the text display correctly with any tab length setting. This has been somehow agreed on linux-kernel (though definitely not unanimously) and I think Barebox tries to duplicate Linux coding style. Not that it matters a lot, can change it all to tabs if that's what Barebox needs. -- Krzysztof Halasa _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
