Re: [PATCH] drivers: mci: Fix compilation warning.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 25, 2010 at 1:48 PM, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 11/25/2010 01:41 PM, Marek Belisko wrote:
>> Fix compilation warning:
>> drivers/mci/mci-core.c:1002:
>> warning: comparison of distinct pointer types lacks a cast
>>
>> Signed-off-by: Marek Belisko <marek.belisko@xxxxxxxxxxxxxxx>
>> ---
>> Âdrivers/mci/mci-core.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
>> index a8aa486..bc82201 100644
>> --- a/drivers/mci/mci-core.c
>> +++ b/drivers/mci/mci-core.c
>> @@ -999,7 +999,7 @@ static int mci_sd_read(struct device_d *disk_dev, uint64_t sector_start,
>> Â Â Â }
>>
>> Â Â Â while (sector_count) {
>> - Â Â Â Â Â Â int now = min(sector_count, 32);
>> + Â Â Â Â Â Â int now = min(sector_count, (unsigned) 32);
>
> for raw numbers you usually add a prefix "U".
Hopefully you mean suffix :) 32U. Will resend.
>
>> Â Â Â Â Â Â Â if (sector_start > MAX_BUFFER_NUMBER) {
>> Â Â Â Â Â Â Â Â Â Â Â pr_err("Cannot handle block number %lu. Too large!\n",
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (unsigned)sector_start);
>
> cheers, Marc
> --
> Pengutronix e.K.         Â| Marc Kleine-Budde      |
> Industrial Linux Solutions    Â| Phone: +49-231-2826-924   |
> Vertretung West/Dortmund     Â| Fax:  +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 Â| http://www.pengutronix.de  |
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
>
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux