[chip@xxxxxxxxxx: Bug#206476: Too many characters are considered 'bad' in extracted binaries]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



As I said in the last bug I forwarded, I don't do much extracting of
binaries from trn so I'm not really qualified to comment on this. What
do people here think of the suggested new BADCHARS default?


Colin Watson                                  [cjwatson@flatline.org.uk]

----- Forwarded message from Chip Salzenberg <chip@debian.org> -----

Subject: Bug#206476: Too many characters are considered 'bad' in extracted binaries
Reply-To: Chip Salzenberg <chip@debian.org>, 206476@bugs.debian.org
Original-Sender: Chip Salzenberg <chip@tytlal.perlsupport.com>
X-Debian-PR-Message: report 206476
X-Debian-PR-Package: trn4
X-Debian-PR-Keywords: patch sid
From: Chip Salzenberg <chip@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Date: Wed, 20 Aug 2003 18:53:45 -0400
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-15.8 required=4.5
	autolearn=ham version=2.53
X-Spam-Checker-Version: SpamAssassin 2.53 (

Package: trn4
Version: 4.0-test76-5
Severity: minor
Tags: sid patch

The built-in list of "bad characters" for extracted filenames is far
too restrictive for modern times.  Many binary files are intentionally
given names containing punctuation, and losing the punctuation
destroys valuable information.  In addition, modern shells are good at
tab completion, which makes such names far less dangerous than they
used to be.

Here's a patch with the list I've decided to use.  You may wish to
trim it even further.

diff -ru2 ../trn4-4.0-test76-5/decode.h ./decode.h
--- ../trn4-4.0-test76-5/decode.h	2000-05-25 01:04:38.000000000 -0400
+++ ./decode.h	2001-09-18 04:49:04.000000000 -0400
@@ -20,5 +20,5 @@
-#define BADCHARS "!$&*()|\'\";<>[]{}?/`\\ \t"
+#define BADCHARS "!$&*()|\";<>[]?/`\\\t"
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux tytlal 2.4.22pre10ax #4 Mon Aug 4 13:09:23 EDT 2003 i686

Versions of packages trn4 depends on:
ii  debconf                 1.3.8            Debian configuration management sy
ii  inn2-inews [inews]      2.4.0+20030808-1 NNTP client news injector, from In
ii  libc6                   2.3.2-3          GNU C Library: Shared libraries an
ii  libncurses5             5.3.20030719-1   Shared libraries for terminal hand

-- debconf information:

----- End forwarded message -----

This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.

[Index of Archives]     [Photo]     [Yosemite]     [Epson Inkjet]     [Mhonarc]     [Nntpcache]

  Powered by Linux