[chip@xxxxxxxxxx: Bug#206475: Decoding filename with trailing dot doesn't imply suffix]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi folks,

Does this patch look sensible? It does to me, but I don't decode binary
files from trn very often. (Perhaps '_' could also be allowed following
'.' - I seem to remember that happening occasionally back when I used to
use Windows.)


Colin Watson                                  [cjwatson@flatline.org.uk]

----- Forwarded message from Chip Salzenberg <chip@debian.org> -----

Subject: Bug#206475: Decoding filename with trailing dot doesn't imply suffix
Reply-To: Chip Salzenberg <chip@debian.org>, 206475@bugs.debian.org
Original-Sender: Chip Salzenberg <chip@tytlal.perlsupport.com>
X-Debian-PR-Message: report 206475
X-Debian-PR-Package: trn4
X-Debian-PR-Keywords: patch sid
From: Chip Salzenberg <chip@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Date: Wed, 20 Aug 2003 18:50:53 -0400
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-15.8 required=4.5
	autolearn=ham version=2.53
X-Spam-Checker-Version: SpamAssassin 2.53 (

Package: trn4
Version: 4.0-test76-5
Severity: normal
Tags: patch sid

When decoding binary flies, trn4 looks for a dot to indicate a file
suffix.  However, a _trailing_ dot should not be considered a suffix
marker.  Here's a patch.

diff -ru2 ../trn4-4.0-test76-5/decode.c ./decode.c
--- ../trn4-4.0-test76-5/decode.c	2000-11-24 16:53:24.000000000 -0500
+++ ./decode.c	2001-11-07 16:09:23.000000000 -0500
@@ -145,5 +145,5 @@
 	while (isalnum(*s) || *s == '-' || *s == '+' || *s == '&'
 	      || *s == '_' || *s == '.') {
-	    if (*s++ == '.')
+	    if (*s++ == '.' && *s && isalnum(*s))
 		hasdot = 1;

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux tytlal 2.4.22pre10ax #4 Mon Aug 4 13:09:23 EDT 2003 i686

Versions of packages trn4 depends on:
ii  debconf                 1.3.8            Debian configuration management sy
ii  inn2-inews [inews]      2.4.0+20030808-1 NNTP client news injector, from In
ii  libc6                   2.3.2-3          GNU C Library: Shared libraries an
ii  libncurses5             5.3.20030719-1   Shared libraries for terminal hand

-- debconf information:

----- End forwarded message -----

This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.

[Index of Archives]     [Photo]     [Yosemite]     [Epson Inkjet]     [Mhonarc]     [Nntpcache]

  Powered by Linux