Re: Resend: Samba 4 patch for kdenetwork/tdenetwork component.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne po 14. října 2019 Andrew Randrianasulu napsal(a):
> В сообщении от Monday 14 October 2019 14:50:00 Slávek Banko написал(а):
> > Dne po 14. října 2019 Andrew Randrianasulu napsal(a):
> > > В сообщении от Monday 14 October 2019 10:29:07 Slávek Banko 
написал(а):
> > > > On Monday 14 of October 2019 05:03:56 Andrew Randrianasulu wrote:
> > > > > В сообщении от Sunday 13 October 2019 14:00:57 Michele Calgaro
> > > > > via
> > > >
> > > > trinity-devel написал(а):
> > > > > > On 2019/10/08 10:44 AM, Andrew Randrianasulu wrote:
> > > > > > > Hello!
> > > > > > >
> > > > > > > I was trying to build my own KDE3-based LiveCD (based on
> > > > > > > Slackware 14.1!). While most things worked - samba
> > > > > > > configuration using KDE's own config module from kcontrol
> > > > > > > showed mostly greyed-out fields.
> > > > > > >
> > > > > > > Aw ....
> > > > > > >
> > > > > > > I looked at
> > > > > > > http://mirror.git.trinitydesktop.org/cgit/tdenetwork/tree/fi
> > > > > > >lesh arin g/advanced/kcm_sambaconf/sambafile.cpp
> > > > > > >
> > > > > > > and tadam!
> > > > > >
> > > > > > Thanks Andrew, good work.
> > > > > > Can you upload your work in pull rquest form on TGW? That way
> > > > > > your work won't get lost within many other things... See here
> > > > > > for a giude on how to do that.
> > > > > > https://wiki.trinitydesktop.org/TDE_Gitea_Workspace
> > > > >
> > > > > Not quite pull request, only issue:
> > > > >
> > > > > https://mirror.git.trinitydesktop.org/gitea/TDE/tdenetwork/issue
> > > > >s/15
> > > > >
> > > > > {I still use kde 3.5.10, building 'real' TDE will require some
> > > > > more effort from my side. After I finally will be pushed to move
> > > > > to 64-bit OS, I think .... quite soon, looking at trends}
> > > > >
> > > > > > Cheers and keep up the good work!
> > > > > >   Michele
> > > > > >
> > > > > :} thanks.
> > > >
> > > > Hi Andrew,
> > > >
> > > > now, as a member of the Contributors team, you can even create a
> > > > pull-request. Don't forget to mention something like "This
> > > > resolves issue #15" in the git commit message.
> > > >
> > > > Cheers
> > >
> > > Made patch with 'git format-patch'. (removed few  whitespaces in the
> > > process)
> > >
> > > Can anyone check if it compiles and works in context of TDE, as
> > > opposed to KDE3?
> >
> > After cloning a repository from TGW, you can use the
> > https://mirror.git.trinitydesktop.org/gitea/TDE/scripts/src/branch/mas
> >ter/switch_all_submodules_to_head_and_clean script to take care of
> > cloning submodules from the same source - from TGW.
> >
> > In the git message, just use the phrase "issue #15" (without
> > specifying the URL), since the TGW automatically displays such
> > references as links.
> >
> > For git commit, it is necessary to use the "-s" option => to add a
> > Signed-off-by line by which you declare DCO consent.
>
> Like this?
>
> > Thank you.
> >
> > Cheers

Pushed to TGW as branch issue/15/samba4:

https://mirror.git.trinitydesktop.org/gitea/TDE/tdenetwork/commit/98dcb944ff
https://mirror.git.trinitydesktop.org/gitea/TDE/tdenetwork/src/branch/issue/15/samba4

It now seems to be ready to create a pull-request :)

Cheers
-- 
Slávek

---------------------------------------------------------------------
To unsubscribe, e-mail: trinity-devel-unsubscribe@xxxxxxxxxxxxxxxxxxxxxxxxxx
For additional commands, e-mail: trinity-devel-help@xxxxxxxxxxxxxxxxxxxxxxxxxx
Read list messages on the web archive: http://trinity-devel.pearsoncomputing.net/
Please remember not to top-post: http://trinity.pearsoncomputing.net/mailing_lists/#top-posting





[Index of Archives]     [Trinity Users]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [KDE]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]     [Trinity Desktop Environment]

  Powered by Linux