On Thu, 2017-02-02 at 20:34 +0100, David Disseldorp wrote: > But do you see the stuck core_tmr_lun_reset and > iscsit_cause_connection_reinstatement threads? Sorry but I don't see that. > I could have worded my report better. The "lockup" I was referring to > was the initiator awaiting TMF response and never getting one - which > doesn't happen with mainline. > > This is easiest to reproduce with: > iscsi-test-cu --test=ALL.iSCSITMF.LUNResetSimpleAsync ... > and then > iscsi-test-cu --test=ALL.MultipathIO.Reset ... (you'll need to provide > your IQN twice for MPIO) > > If you run MultipathIO.Reset before iSCSITMF.LUNResetSimpleAsync then > it runs fine (ignoring the test failure), if you run it afterwards then > it blocks indefinitely, as LIO never sends a TMF response. Sorry but even with that test sequence I don't see the initiator waiting longer than expected. As one can see below both tests complete in a few milliseconds: $ ./iscsi-test-cu --dataloss -t iSCSI.iSCSITMF.LUNResetSimpleAsync iscsi://127.0.0.1/tgt1/0 && ./iscsi-test-cu --dataloss -t ALL.MultipathIO.Reset iscsi://127.0.0.1/tgt1/0 iscsi://127.0.0.1/tgt1/0 [SKIPPED] REPORT_SUPPORTED_OPCODES is not implemented. CUnit - A unit testing framework for C - Version 2.1-3 http://cunit.sourceforge.net/ Suite: iSCSITMF Test: LUNResetSimpleAsync ...passed Run Summary: Type Total Ran Passed Failed Inactive suites 1 1 n/a 0 0 tests 1 1 1 0 0 asserts 16 16 16 0 n/a Elapsed time = 0.001 seconds Tests completed with return value: 0 skipping non-LU designator: 2 skipping non-LU designator: 1 skipping unsupported des type: 6 skipping non-LU designator: 1 skipping non-LU designator: 1 skipping unsupported des type: 1 skipping non-LU designator: 2 skipping non-LU designator: 1 skipping unsupported des type: 6 skipping non-LU designator: 1 skipping non-LU designator: 1 skipping unsupported des type: 1 found matching LU device identifier for all (2) paths [SKIPPED] REPORT_SUPPORTED_OPCODES is not implemented. CUnit - A unit testing framework for C - Version 2.1-3 http://cunit.sourceforge.net/ Suite: MultipathIO Test: Reset ...FAILED 1. test_multipathio_reset.c:70 - CU_ASSERT_NOT_EQUAL(num_uas,0) 2. test_multipathio_reset.c:70 - CU_ASSERT_NOT_EQUAL(num_uas,0) Run Summary: Type Total Ran Passed Failed Inactive suites 1 1 n/a 0 0 tests 1 1 0 1 0 asserts 12 12 10 2 n/a Elapsed time = 0.002 seconds Tests completed with return value: 0-- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html