On Thu, 2015-05-21 at 15:36 +0200, Bart Van Assche wrote: > On 05/21/15 11:52, Nicholas A. Bellinger wrote: > > You'll need to focus on iscsi-target and tcm_qla2xxx specifically with > > real workloads and backend configurations to prove the changes are > > functionally correct beyond simple VM tests, otherwise I'm not even > > going to consider these type of changes. > > Hello Nic, > > I agree that the target core patches in this series also need to be > tested with other target drivers. The reason I had posted this patch > series prior to that testing was to gather feedback about the approach > of this patch series before running more tests. > I'd prefer you ask the list first before perusing large changes that might be based on incorrect assumptions. Considering the limited amount of experience you've got with the code, and that you're not actually running it in production, I'm very allergic to being told 'this is what I think is wrong, and you need to make these large changes' vs. asking first 'why do things work this way..?" > How about the eight tcm_fc patches in this patch series ? These patches > improve the tcm_fc driver even without the target core patches. > Yes. The bugfixes should be submitted in a separate series from the other changes. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
