On Thu, 2015-05-21 at 11:39 +0200, Bart Van Assche wrote: > On 05/21/15 11:21, Nicholas A. Bellinger wrote: > > Really, this series is not even close to being functionally correct. > > Hello Nic, > > The current approach for handling task management functions in the LIO > core triggers many race conditions. Fixing these is impossible without > either introducing additional locking or doing what I did - moving task > management function handling from the context that processes the TMF to > the command execution context. The approach in this patch series has the > advantage that it makes the TMF handling code much easier to read and to > verify. The series is wrong on many levels, and I'm more than happy to comment on them individually. Using a fabric like FoCE that hardly anyone cares about as your vehicle for rewriting core TMR logic is not going to be enough of a reason. You'll need to focus on iscsi-target and tcm_qla2xxx specifically with real workloads and backend configurations to prove the changes are functionally correct beyond simple VM tests, otherwise I'm not even going to consider these type of changes. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
