On Thu, May 21, 2015 at 02:52:57AM -0700, Nicholas A. Bellinger wrote: > The series is wrong on many levels, and I'm more than happy to comment > on them individually. In general it's more helpful to explain those than just saying things are wrong. > You'll need to focus on iscsi-target and tcm_qla2xxx specifically with > real workloads and backend configurations to prove the changes are > functionally correct beyond simple VM tests, otherwise I'm not even > going to consider these type of changes. One thing that would really help is to have a pre defined set of test available. The libiscsi test suite is pretty useful for CDB level testing, but not that useful for error handling and doesn't touch the vast control plane and shutdown case at all. If a maintainer (rightfully!) demands testing coverage he also needs to point to tests. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
