On 05/21/15 11:52, Nicholas A. Bellinger wrote: > You'll need to focus on iscsi-target and tcm_qla2xxx specifically with > real workloads and backend configurations to prove the changes are > functionally correct beyond simple VM tests, otherwise I'm not even > going to consider these type of changes. OK, I will test this patch series also with other target drivers. BTW, I think the kernel bug shown below illustrates that we really need something like this patch series. The kernel bug below was hit by running the fio + sg_reset test mentioned in the cover letter of this patch series against a target system with the latest target code from the for-next branch. That means target code without the patches from this series to rework task management function handling. Bart. BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<ffffffff8107b29c>] pwq_activate_delayed_work+0x5c/0x220 PGD 52401067 PUD 51966067 PMD 0 Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC Modules linked in: target_core_pscsi target_core_iblock target_core_file tcm_fc target_core_mod fcoe libfcoe libfc scsi_transport_fc netconsole configfs ib_iser rdma_cm iw_cm ib_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi hid_generic af_packet dm_multipath scsi_dh dm_mod usbhid microcode hid virtio_balloon i2c_piix4 i2c_core acpi_cpufreq intel_agp processor intel_gtt agpgart thermal_sys hwmon button fuse sg sr_mod cdrom ata_generic pata_acpi ext4 crc16 jbd2 mbcache virtio_blk virtio_net ata_piix libata uhci_hcd virtio_pci usbcore virtio_ring scsi_mod usb_common virtio [last unloaded: target_core_mod] CPU: 2 PID: 1539 Comm: kworker/2:2 Not tainted 4.1.0-rc1-lio-dbg+ #1 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 task: ffff880050eda4e0 ti: ffff880053eec000 task.ti: ffff880053eec000 RIP: 0010:[<ffffffff8107b29c>] [<ffffffff8107b29c>] pwq_activate_delayed_work+0x5c/0x220 RSP: 0018:ffff880053eefd18 EFLAGS: 00010082 RAX: 0000000080000002 RBX: ffff88005f91f200 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff81a3edc0 RDI: 0000000000000092 RBP: ffff880053eefd38 R08: 0000000000000000 R09: 0000000000000000 R10: ffff88005f914958 R11: 0000000000000000 R12: ffff880059055f88 R13: 0000000000000000 R14: ffff88005f91f200 R15: 0000000000000080 FS: 0000000000000000(0000) GS:ffff88005f900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 0000000000000130 CR3: 000000004feef000 CR4: 00000000000007e0 Stack: ffff88005f914940 ffff88005f91f200 ffff88005f91f200 ffff88005f914940 ffff880053eefd68 ffffffff8107c0cc ffffffff8107cfa1 0000000059055f88 ffff880059055f88 ffff88005975a698 ffff880053eefde8 ffffffff8107d002 Call Trace: [<ffffffff8107c0cc>] pwq_dec_nr_in_flight+0x6c/0xc0 [<ffffffff8107d002>] process_one_work+0x2f2/0x880 [<ffffffff8107d5fb>] worker_thread+0x6b/0x4b0 [<ffffffff8108377a>] kthread+0x10a/0x120 [<ffffffff81503322>] ret_from_fork+0x42/0x70 Code: 05 aa f7 f8 7e 48 8b 05 53 18 a4 00 e8 2e 5f 04 00 85 c0 74 0d 80 3d 61 06 a4 00 00 0f 84 ed 00 00 00 65 ff 0d 86 f7 f8 7e 74 7c <49> 8b 45 00 31 d2 4c 89 e7 48 8d 70 48 e8 82 d5 ff ff 41 0f ba RIP [<ffffffff8107b29c>] pwq_activate_delayed_work+0x5c/0x220 RSP <ffff880053eefd18> CR2: 0000000000000000 ---[ end trace 3c38ce37e8a5a8f1 ]--- -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
