On Thu, May 07, 2015 at 01:39:30PM -0700, Andy Grover wrote: > I've implemented a patch for #1, here it is: > > https://git.kernel.org/cgit/linux/kernel/git/grover/linux.git/commit/?h=tcmu-iomode-option1&id=01616b20311a9826ae1cb1806f93f1574a0fbfbd > > Wasn't thrilled with how it turned out. It looks pretty ugly indeed. What I though you meant was just passing through all I/O commans as SCSI CDBs, which would be different again, but maybe not any less ugly. > How about if we just exclude the > troublesome opcodes (option #5)? They'd still be available in > full-passthrough mode... > > https://git.kernel.org/cgit/linux/kernel/git/grover/linux.git/commit/?h=tcmu-iomode-option5&id=d0cd27e791d3efc4967b958d4572e1764feb668a That looks way better, but I'd defintively prefer a switch statement for the opcode handling. But what I still don't quite understand is why allowing COMPARE_AND_WRITE as-is isn't an option for you. Given how it is sequenced into individual reads and writes it should work just fine. Do you have a testcase showing how it doesn't work? -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
