On 05/08/2015 10:08 AM, Bart Van Assche wrote: > Correct the comment above the definition of TCM_MAX_COMMAND_SIZE. > A quote from Christoph: > > There aren't any legacy issues, we just decided to handle > > 16 byte CDBs in the slow path. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Cc: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxx> > Cc: Mike Christie <michaelc@xxxxxxxxxxx> > --- > include/target/target_core_base.h | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h > index 480e9f8..0203774 100644 > --- a/include/target/target_core_base.h > +++ b/include/target/target_core_base.h > @@ -17,16 +17,8 @@ > /* Don't raise above 511 or REPORT_LUNS needs to handle >1 page */ > #define TRANSPORT_MAX_LUNS_PER_TPG 256 > /* > - * By default we use 32-byte CDBs in TCM Core and subsystem plugin code. > - * > - * Note that both include/scsi/scsi_cmnd.h:MAX_COMMAND_SIZE and > - * include/linux/blkdev.h:BLOCK_MAX_CDB as of v2.6.36-rc4 still use > - * 16-byte CDBs by default and require an extra allocation for > - * 32-byte CDBs to because of legacy issues. > - * > - * Within TCM Core there are no such legacy limitiations, so we go ahead > - * use 32-byte CDBs by default and use include/scsi/scsi.h:scsi_command_size() > - * within all TCM Core and subsystem plugin code. > + * Maximum size of a CDB that can be stored in se_cmd without allocating > + * memory dynamically for the CDB. > */ > #define TCM_MAX_COMMAND_SIZE 32 > /* > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
