This looks good to me, Reviewed-by: Christoph Hellwig <hch@xxxxxx> But while reviewing this I noticed another oddity: tcmu totally ignores the non-cmd arguments to tcmu_execute_rw. These arguments exist to support commands like COMPARE AND WRITE that first do a read and then a write pass, which scb_parse_cdb will hapilly accept, but which will be broken with tcmu. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html