On Fri, 2014-06-13 at 14:03 +0530, Rahul Rane wrote: > Hi, > > I am trying to understand how LIO implements CHAP_C in case where binary > length is less than 1 byte. The RFC talks about the > maximum values however the minimum values is left open by the RFC. For > example , If I am sending a less than 1 byte data ( 0xA - or 4 bits ) > how should LIO respond to it. What I am seeing is that currently it is > accepting the login with success. Is it a valid case to probe. ? > Waiting for > your comments. > So I can't find anything about a minimum challenge length in the related RFCs, but elsewhere in various vendor documentation for CHAP beyond it's use in iSCSI (eg: PPP) the minimum value is 16 bytes. This would probably be a good starting point for enforcing a minimum in iscsi-target, but I'd like to first verify this assumption doesn't break compatibility with any existing initiators, as it's not something the initiator side user can control. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html