Sorry my mistake again, i dont know why was there still old path when size and date of module is correct one, But i recompiled again, rebooted everything and now it works like it should. root@test:~# sg_inq -H /dev/sdb standard INQUIRY: 00 00 00 05 02 1f b0 00 02 4c 49 4f 2d 47 52 4f 20 ........LIO-GRO 10 49 42 4c 4f 43 4b 20 20 20 20 20 20 20 20 20 20 IBLOCK 20 34 2e 30 00 4.0. And also now Falcostor correctly recognize LUN with ALUA: Hardware ID LIO-ORG IBLOCK -2ec2d6c0-d766-4a33-bc35-bf7c7331-60014052ec2d6c0d7664a33bc35bf7c7-02 Inquiry String 000005021fb00002LIO-ORG IBLOCK 4.0_ Thank you for your time and for your help, you can include this patch in feature release, this is correct inquiry string. Thanks again. S pozdravom / Best regards Tomas Molota Chief Technology Officer Parickova 18, 821 08 Bratislava, Slovakia e-mail: tomas.molota@xxxxxxxxxxxxx web: www.lightstorm.sk phone: +421 2 32 400 011 cell phone: +421 903 788 100 -----Original Message----- From: Nicholas A. Bellinger [mailto:nab@xxxxxxxxxxxxxxx] Sent: Monday, July 29, 2013 9:01 PM To: Tomas Molota Cc: 'Roland Dreier'; 'target-devel' Subject: Re: FCoE Target naming - help On Sat, 2013-07-27 at 21:09 +0200, Tomas Molota wrote: > Sorry, wrong kernel. I booted with correct one. > root@test:~# sg_inq -H /dev/sdb > standard INQUIRY: > 00 00 00 05 02 1f b0 00 02 4c 49 4f 2d 4f 52 47 20 ........LIO-ORG > 10 49 42 4c 4f 43 4b 00 00 00 00 00 00 00 00 00 00 IBLOCK.......... > 20 34 2e 30 00 4.0. > So difference is after ORG is 20, but after IBLOCK still 00 > Hi Tomas, I still don't think that your using the correct version of the patch. (Eg: you applied v1, but not the updated v2 below). Again, please confirm that your using the v2 below that uses memcpy() + strlen() for the inquiry MODEL. Thanks, --nab diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c index 4cb667d..9fabbf7 100644 --- a/drivers/target/target_core_spc.c +++ b/drivers/target/target_core_spc.c @@ -97,9 +97,12 @@ spc_emulate_inquiry_std(struct se_cmd *cmd, unsigned char *buf) buf[7] = 0x2; /* CmdQue=1 */ - snprintf(&buf[8], 8, "LIO-ORG"); - snprintf(&buf[16], 16, "%s", dev->t10_wwn.model); - snprintf(&buf[32], 4, "%s", dev->t10_wwn.revision); + memcpy(&buf[8], "LIO-ORG ", 8); + memset(&buf[16], 0x20, 16); + memcpy(&buf[16], dev->t10_wwn.model, + min_t(size_t, strlen(dev->t10_wwn.model), 16)); + memcpy(&buf[32], dev->t10_wwn.revision, + min_t(size_t, strlen(dev->t10_wwn.revision), 4)); buf[4] = 31; /* Set additional length to 31 */ return 0; > S pozdravom / Best regards > > Tomas Molota > Chief Technology Officer > > > Parickova 18, 821 08 Bratislava, Slovakia > e-mail: tomas.molota@xxxxxxxxxxxxx > web: www.lightstorm.sk > phone: +421 2 32 400 011 > cell phone: +421 903 788 100 > > -----Original Message----- > From: Nicholas A. Bellinger [mailto:nab@xxxxxxxxxxxxxxx] > Sent: Saturday, July 27, 2013 8:38 PM > To: Tomas Molota > Cc: 'Roland Dreier'; 'target-devel' > Subject: Re: FCoE Target naming - help > > On Sat, 2013-07-27 at 09:19 +0200, Tomas Molota wrote: > > Ok Nicholas i finaly have it and it looks like this: > > root@test:~# sg_inq -H /dev/sdb > > standard INQUIRY: > > 00 00 00 05 02 1f b0 00 02 4c 49 4f 2d 4f 52 47 00 ........LIO-ORG. > > 10 49 42 4c 4f 43 4b 00 00 00 00 00 00 00 00 00 00 IBLOCK.......... > > 20 34 2e 30 00 4.0. > > > > There are 00 chars instead of 20 > > Thanks, so this confirms that the previous patch has not been properly applied and/or updated kernel rebuilt + installed on your target side setup. > > Please double check that the same patch (included below) and updated target_core_mod.ko are being correctly installed. > > Thanks! > > --nab > > diff --git a/drivers/target/target_core_spc.c > b/drivers/target/target_core_spc.c > index 4cb667d..9fabbf7 100644 > --- a/drivers/target/target_core_spc.c > +++ b/drivers/target/target_core_spc.c > @@ -97,9 +97,12 @@ spc_emulate_inquiry_std(struct se_cmd *cmd, > unsigned char *buf) > > buf[7] = 0x2; /* CmdQue=1 */ > > - snprintf(&buf[8], 8, "LIO-ORG"); > - snprintf(&buf[16], 16, "%s", dev->t10_wwn.model); > - snprintf(&buf[32], 4, "%s", dev->t10_wwn.revision); > + memcpy(&buf[8], "LIO-ORG ", 8); > + memset(&buf[16], 0x20, 16); > + memcpy(&buf[16], dev->t10_wwn.model, > + min_t(size_t, strlen(dev->t10_wwn.model), 16)); > + memcpy(&buf[32], dev->t10_wwn.revision, > + min_t(size_t, strlen(dev->t10_wwn.revision), 4)); > buf[4] = 31; /* Set additional length to 31 */ > > return 0; > root@haakon3:/usr/src/target-pending.git# > > > > > > standard INQUIRY: > > 00 00 00 04 32 5b 18 00 02 46 41 4c 43 4f 4e 20 20 ...2[...FALCON > > 10 49 50 53 54 4f 52 20 44 49 53 4b 20 20 20 20 20 IPSTOR DISK > > 20 76 31 2e 30 44 45 59 51 49 31 51 33 57 37 33 58 v1.0DEYQI1Q3W73X > > 30 20 20 20 20 20 20 20 20 00 00 00 40 09 60 02 60 ...@.`.` > > 40 03 20 00 00 00 00 00 00 00 00 00 00 00 00 00 00 . .............. > > 50 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > > > > host7 LUNs: > > Path Device Size Vendor Model State > > 7:0:0:0 sdb 53 GB LIO-ORG IBLOCK running > > 7:0:0:1 sdc 107 GB LIO-ORG IBLOCK running > > 7:0:0:2 sdd 161 GB LIO-ORG IBLOCK running > > 7:0:7:0 sde 429 GB FALCON IPSTOR DISK running > > 7:0:8:0 sdf 429 GB FALCON IPSTOR DISK running > > > > > > S pozdravom / Best regards > > > > Tomas Molota > > Chief Technology Officer > > > > > > Parickova 18, 821 08 Bratislava, Slovakia > > e-mail: tomas.molota@xxxxxxxxxxxxx > > web: www.lightstorm.sk > > phone: +421 2 32 400 011 > > cell phone: +421 903 788 100 > > > > -----Original Message----- > > From: Nicholas A. Bellinger [mailto:nab@xxxxxxxxxxxxxxx] > > Sent: Saturday, July 27, 2013 12:00 AM > > To: Tomas Molota > > Cc: 'Roland Dreier'; 'target-devel' > > Subject: Re: FCoE Target naming - help > > > > On Fri, 2013-07-26 at 22:43 +0200, Tomas Molota wrote: > > > Here is tshark dump from target server. I dont see there inquiry string. > > > > > > > Mmmm, strange the capture only contains the incoming (and not outgoing) FCP packets to the FCoE target.. > > > > Would it be possible to just hookup a normal Linux FCoE initiator in order to verify sg_inq -H output..? > > > > Thanks, > > > > --nab > > > > > S pozdravom / Best regards > > > > > > Tomas Molota > > > Chief Technology Officer > > > > > > > > > Parickova 18, 821 08 Bratislava, Slovakia > > > e-mail: tomas.molota@xxxxxxxxxxxxx > > > web: www.lightstorm.sk > > > phone: +421 2 32 400 011 > > > cell phone: +421 903 788 100 > > > > > > -----Original Message----- > > > From: Nicholas A. Bellinger [mailto:nab@xxxxxxxxxxxxxxx] > > > Sent: Friday, July 26, 2013 9:41 PM > > > To: Tomas Molota > > > Cc: 'Roland Dreier'; 'target-devel' > > > Subject: Re: FCoE Target naming - help > > > > > > On Fri, 2013-07-26 at 21:03 +0200, Tomas Molota wrote: > > > > Nope, its not in /dev/ in any way, only where i found something > > > > about it is in > > > > /sys/devices/pci0000:00/0000:00:02.0/0000:04:00.0/host100/rport-100:0-4/ etc.. > > > > > > Mmmm.. > > > > > > > Problem is that wireshark will not help in this combination, > > > > becouse linux is FCoE target, but FalconStor is pure FC > > > > initiator with modified qla2x00 driver. > > > > > > Why is it not possible to capture ethernet packets from the FCoE target using wireshark..? > > > > > > http://wiki.wireshark.org/FCoE > > > > > > --nab > > > > > > > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe > target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
