On Jul 30 Andy Grover wrote: > Hi Chris, > > >From drivers/target/sbp/sbp_target.c sbp_tpg_store_enable() (line 2361): > > if (val) { > if (sbp_count_se_tpg_luns(&tpg->se_tpg) == 0) { > pr_err("Cannot enable a target with no LUNs!\n"); > return -EINVAL; > } > }... > > rtslib enables TPGs when they are created (before luns have been added), > and thus triggers this -EINVAL. Is this check strictly necessary for sbp? Has this been resolved in the meantime? According to the SBP-2 and SBP-3 specs, there has to be at least one logical unit. So, if it is desirable to establish target instances without having a logical unit during the entire lifetime, then the implementation would have to keep this target invisible to the external bus for as long as there is no logical unit. There should be no SBP-2/ SBP-3 unit directory in the 1394 Configuration ROM without at least one logical unit entry. -- Stefan Richter -=====-===-- =--= ===-- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html