enabling a target with no luns

[Andy Grover <agrover@xxxxxxxxxx>]

Hi Chris,

>From drivers/target/sbp/sbp_target.c sbp_tpg_store_enable() (line 2361):

if (val) {
        if (sbp_count_se_tpg_luns(&tpg->se_tpg) == 0) {
                pr_err("Cannot enable a target with no LUNs!\n");
                return -EINVAL;
        }
}...

rtslib enables TPGs when they are created (before luns have been added),
and thus triggers this -EINVAL. Is this check strictly necessary for sbp?

Thanks -- Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html