On Wed, 2012-07-25 at 02:20 -0400, Stefan Richter wrote: > d) Adding units on Linux nodes: > > Yes, firewire-core is implemented such that a driver's (userspace or > kernel driver's) request to add a logical unit directory to the > Configuration ROM affects the Configuration ROMs of /all/ logical nodes at > once. > > It is merely an implementation limitation which was chosen to keep things > simple. The present drivers/firewire/ stack exists in the mainline today > instead of former Linux's drivers/ieee1394/ stack because it provided a > fresh start with a much slimmer code base, bringing design fixes as well > as new features while coming in much less and more modern source code for > better maintainability. > > So in short, not offering the ability to add a unit directory only to a > single local node's Configuration ROM was merely a decision for the > benefit of slimmer code. > > If anybody is interested in this missing feature, propose a patch. This brings up an interesting point: does the present stack provide any guarantee that the local unit device is probed/created before the corresponding remote unit device is probed/created? Take the case where a unit driver on the local node adds a Config ROM unit directory. Then, at some subsequent bus reset, the remote node builds the topo tree and creates a unit device for (from its POV) the remote unit. Is it possible that the local node has not yet built the topo tree and created the local unit device? Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
