On 07/24/2012 11:45 PM, Nicholas A. Bellinger wrote: >> > diff --git a/drivers/vhost/tcm_vhost.h b/drivers/vhost/tcm_vhost.h >> > index e942df9..3d5378f 100644 >> > --- a/drivers/vhost/tcm_vhost.h >> > +++ b/drivers/vhost/tcm_vhost.h >> > @@ -80,7 +80,17 @@ struct tcm_vhost_tport { >> > >> > #include <linux/vhost.h> >> > >> > +/* >> > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. >> > + * >> > + * ABI Rev 0: All pre 2012 revisions used by prototype out-of-tree code >> > + * ABI Rev 1: 2012 version for v3.6 kernel merge candiate >> > + */ If it's out of tree, why consider it at all? Put a stable ABI in tree and extend it in compatible ways. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html