Re: [PATCH 1/2] target: Return correct ASC for unimplemented VPD pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-01-17 at 18:00 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> 
> My draft of SPC-4 says:
> 
>     If the device server does not implement the requested vital product
>     data page, then the command shall be terminated with CHECK CONDITION
>     status, with the sense key set to ILLEGAL REQUEST, and the
>     additional sense code set to INVALID FIELD IN CDB.
> 
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
>  drivers/target/target_core_cdb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
> index 831468b..c23bc47 100644
> --- a/drivers/target/target_core_cdb.c
> +++ b/drivers/target/target_core_cdb.c
> @@ -720,7 +720,7 @@ int target_emulate_inquiry(struct se_task *task)
>  	}
>  
>  	pr_err("Unknown VPD Code: 0x%02x\n", cdb[2]);
> -	cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE;
> +	cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD;
>  	ret = -EINVAL;
>  
>  out_unmap:

Applied.  Thanks Roland!

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux