On Tue, 2012-01-17 at 18:00 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
>
> My draft of SPC-4 says:
>
> If the PAGE CODE field is not set to zero when the EVPD bit is set
> to zero, the command shall be terminated with CHECK CONDITION
> status, with the sense key set to ILLEGAL REQUEST, and the
> additional sense code set to INVALID FIELD IN CDB.
>
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
> drivers/target/target_core_cdb.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
> index c23bc47..c564979 100644
> --- a/drivers/target/target_core_cdb.c
> +++ b/drivers/target/target_core_cdb.c
> @@ -689,6 +689,13 @@ int target_emulate_inquiry(struct se_task *task)
> int p, ret;
>
> if (!(cdb[1] & 0x1)) {
> + if (cdb[2]) {
> + pr_err("INQUIRY with EVPD==0 but PAGE CODE=%02x\n",
> + cdb[2]);
> + cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD;
> + return -EINVAL;
> + }
> +
> ret = target_emulate_inquiry_std(cmd);
> goto out;
> }
Also applied to lio-core. Thanks!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
