Re: [PATCH 2/2] tcm_qla2xxx: Drop pci_get_drvdata from tcm_qla2xxx_npiv_make_lport

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Nov 10, 2011 at 10:15:22PM +0000, Nicholas A. Bellinger wrote:
> +#warning FIXME: tcm_qla2xxx_npiv_make_lport
> +	ret = -ENOSYS;

I'm really not a fan of adding #warning - these make it hard to check
the compiler for real warnings.  Just use a comment tag that you can
easily grep for, e.g.

	XXX(nab):

or

	FIXME(nab):

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html