On Sat, Nov 12, 2011 at 10:14:43AM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > This patch moves target_put_sess_cmd() to use a se_cmd->cmd_kref > callback target_release_cmd_kref when performing driver release of > fabric->se_cmd descriptor memory. It sets the default cmd_kref > count value to '2' within target_get_sess_cmd() setup, and > currently assumes TFO->check_stop_free() usage. > > It drops se_tfo->check_release_cmd() usage in the main > transport_release_cmd codepath. I'm a bit worried about this as we now have a partial refconting for the se_cmd. Can't we always use the kref, but only grab one reference to it for drivers not using the session tracking? Or as suggest before always do the session tracking, but only use it for active I/O shutdown conditionally. > +/* target_put_sess_cmd - Check for active I/O shutdown via kref_put Not quite correct for kerneldoc style either. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
