> +/** qla_tgt_lport_register() - Register lport with external module
> + *
the kernel doc format requires the function name not to be on the first
line, and not to use braces, e.g.
/**
* qla_tgt_lport_register - register lport with external module
also generally there's little capitalization in the right hand sides of
the kerneldoc markup, like above and in the argument descriptions.
> + for (i = 0; i < 8; i++)
> + pr_debug("%02x ", vha->node_name[i]);
> + pr_debug("\n");
> + pr_debug("qla2xxx HW vha->port_name: ");
> + for (i = 0; i < 8; i++)
> + pr_debug("%02x ", vha->port_name[i]);
> + pr_debug("\n");
> +
> + pr_debug("qla2xxx passed configfs WWPN: ");
> + put_unaligned_be64(wwpn, b);
> + for (i = 0; i < 8; i++)
> + pr_debug("%02x ", b[i]);
> + pr_debug("\n");
Move the debug dumps into a separate funtion?
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
