Looks good, autogeneration EPVD 00 makes a lot more sense than having to opencode it in different places. > + /* > + * Only report the INQUIRY EVPD=1 pages after a valid NAA > + * Registered Extended LUN WWN has been set via ConfigFS > + * during device creation/restart. > + */ > + if (cmd->se_dev->se_sub_dev->su_dev_flags & > + SDF_EMULATED_VPD_UNIT_SERIAL) { I don't think this check makes sense for all VPD pages, but only those actually containing the serial number or similar identifiers. Then again it's not making things worse for now. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html