On Wed, Jul 6, 2011 at 12:22 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> + /*
>> + * Only report the INQUIRY EVPD=1 pages after a valid NAA
>> + * Registered Extended LUN WWN has been set via ConfigFS
>> + * during device creation/restart.
>> + */
>> + if (cmd->se_dev->se_sub_dev->su_dev_flags &
>> + SDF_EMULATED_VPD_UNIT_SERIAL) {
> I don't think this check makes sense for all VPD pages, but only those
> actually containing the serial number or similar identifiers. Then
> again it's not making things worse for now.
Good point. In fact my patch would make it easier to fix that, since we
could just add a flag to the table of vpd pages that says whether we need
a serial number for that page. I'll add that to my list of things to do once
this gets merged up.
Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
