Re: [PATCH 1/3] target: Allow for built-in target modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 05, 2011 at 01:34:50PM -0700, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> 
> In target_fabric_configfs_init(), we should allow fabric_mod to be NULL,
> since THIS_MODULE is NULL for built-in modules.  The main method of
> using the target code may be as modules, but having everything built-in
> is useful eg to be able to do quick testing with "qemu -kernel".
> 
> In any case, we shouldn't bomb out fabric registration for a perfectly
> valid configuration, so simply drop the check of fabric_mod.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux