Re: [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

[Lennart Poettering <lennart@xxxxxxxxxxxxxx>]

On Mi, 29.07.20 08:57, Ian Kent (ikent@xxxxxxxxxx) wrote:

> On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote:
> > On Mo, 27.07.20 12:57, Ian Kent (ikent@xxxxxxxxxx) wrote:
> >
> > > Further to my post about using the new mount table notifications in
> > > systemd I'd like to start by posting a few patches for discussion
> > > to
> > > hopefully get a better understanding of some aspects of how systemd
> > > mount unit state handling works, and also to get guidance on
> > > systemd
> > > coding style, and generally how I should be doing things in systemd
> > > as well as how best to debug problems.
> >
> > Thank you for working on this!
> >
> > We do reviews exclusively on github these days, could you please
> > submit this as PR on github?
>
> Thanks Lennart, will do.
>
> Although I was hoping for some generic discussion on this to set
> me going in the right direction.
>
> If that's not ok then I'll submit a PR when I think it's ready.

I am sorry, but we do code review in gitub. It's what it is good
for. If you want reviews on patches, even if thery are RFCs, post them
as PR, like everyone else.

PRs are general code commenting tools, they are not exclusively for
"final" versions.

Lennart

--
Lennart Poettering, Berlin
_______________________________________________
systemd-devel mailing list
systemd-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/systemd-devel