Re: [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

[Ian Kent <ikent@xxxxxxxxxx>]

On Mon, 2020-08-03 at 11:34 +0200, Lennart Poettering wrote:
> On Mi, 29.07.20 08:57, Ian Kent (ikent@xxxxxxxxxx) wrote:
> 
> > On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote:
> > > On Mo, 27.07.20 12:57, Ian Kent (ikent@xxxxxxxxxx) wrote:
> > > 
> > > > Further to my post about using the new mount table
> > > > notifications in
> > > > systemd I'd like to start by posting a few patches for
> > > > discussion
> > > > to
> > > > hopefully get a better understanding of some aspects of how
> > > > systemd
> > > > mount unit state handling works, and also to get guidance on
> > > > systemd
> > > > coding style, and generally how I should be doing things in
> > > > systemd
> > > > as well as how best to debug problems.
> > > 
> > > Thank you for working on this!
> > > 
> > > We do reviews exclusively on github these days, could you please
> > > submit this as PR on github?
> > 
> > Thanks Lennart, will do.
> > 
> > Although I was hoping for some generic discussion on this to set
> > me going in the right direction.
> > 
> > If that's not ok then I'll submit a PR when I think it's ready.
> 
> I am sorry, but we do code review in gitub. It's what it is good
> for. If you want reviews on patches, even if thery are RFCs, post
> them
> as PR, like everyone else.
> 
> PRs are general code commenting tools, they are not exclusively for
> "final" versions.

Yes, I've been looking at the systemd PR's and I see that.

I'm fairly confident that the core functionality is working now
so I'm not so concerned about feedback about what's happening in
systemd any more. And it appears the reduction in overhead is quite
significant as was expected.

I've also made adjustments based on the systemd coding style notes
which I found because you pointed me at github above, that's been
useful too.

But there's a bit more to do before I can raise a PR.

Handling notification buffer overflow (and fall back to the old
method) testing needs to be done. And also more testing of various
cases and adjustments that may come out of it, as well as a meson
build change so systemd builds against a libmount without the new
changes.

And finally I'll need to re-test all this when David's changes are
merged upstream.

Thanks for the feedback,
Ian

_______________________________________________
systemd-devel mailing list
systemd-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/systemd-devel