Re: [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

[Ian Kent <ikent@xxxxxxxxxx>]

On Mon, 2020-08-03 at 09:30 +0100, Colin Guthrie wrote:
> Ian Kent wrote on 29/07/2020 01:57:
> > On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote:
> > > On Mo, 27.07.20 12:57, Ian Kent (ikent@xxxxxxxxxx) wrote:
> > > 
> > > > Further to my post about using the new mount table
> > > > notifications in
> > > > systemd I'd like to start by posting a few patches for
> > > > discussion
> > > > to
> > > > hopefully get a better understanding of some aspects of how
> > > > systemd
> > > > mount unit state handling works, and also to get guidance on
> > > > systemd
> > > > coding style, and generally how I should be doing things in
> > > > systemd
> > > > as well as how best to debug problems.
> > > 
> > > Thank you for working on this!
> > > 
> > > We do reviews exclusively on github these days, could you please
> > > submit this as PR on github?
> > 
> > Thanks Lennart, will do.
> > 
> > Although I was hoping for some generic discussion on this to set
> > me going in the right direction.
> > 
> > If that's not ok then I'll submit a PR when I think it's ready.
> 
> Although I'm not as familiar with the development process as I used
> to
> be, you can file it now, even in it's current state for that
> discussion
> process. It can be an RFC Pull request. Just means the discussion can
> all take place in Github and can go through various iterations there.
> 
> So, in short, don't worry about it being fully "ready" before pushing
> and doing a pull requests.

I know I said I wasn't quite ready but your right, there's bound to be
good advice about what I've done and what might need to change, at
least now I have something that seems to behave as it's supposed to, ;)

Ian

_______________________________________________
systemd-devel mailing list
systemd-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/systemd-devel