On Sat, Sep 14, 2024 at 03:32:33AM -0700, Ron Economos wrote: > On 9/14/24 3:04 AM, Xingyu Wu wrote: > > On 14/09/2024 17:37, Greg KH wrote: > > > On Sat, Sep 14, 2024 at 09:24:44AM +0000, Xingyu Wu wrote: > > > > On 14/09/2024 16:51, Greg KH wrote: > > > > > On Sat, Sep 14, 2024 at 08:01:44AM +0000, Xingyu Wu wrote: > > > > > > On 13/09/2024 22:12, Sasha Levin wrote: > > > > > > > This is a note to let you know that I've just added the patch > > > > > > > titled > > > > > > > > > > > > > > riscv: dts: starfive: jh7110-common: Fix lower rate of > > > > > > > CPUfreq by setting PLL0 rate to 1.5GHz > > > > > > > > > > > > > > to the 6.10-stable tree which can be found at: > > > > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable- > > > > > > > queue.git;a=summary > > > > > > > > > > > > > > The filename of the patch is: > > > > > > > riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch > > > > > > > and it can be found in the queue-6.10 subdirectory. > > > > > > > > > > > > > > If you, or anyone else, feels it should not be added to the > > > > > > > stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > > > > > > > > Hi Sasha, > > > > > > > > > > > > This patch only has the part of DTS without the clock driver patch[1]. > > > > > > [1]: > > > > > > https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star > > > > > > five > > > > > > tech.com/ > > > > > > > > > > > > I don't know your plan about this driver patch, or maybe I missed it. > > > > > > But the DTS changes really needs the driver patch to work and you > > > > > > should add > > > > > the driver patch. > > > > > > > > > > Then why does the commit say: > > > > > > > > > > > > Fixes: e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling > > > > > > > for > > > > > > > JH7110 SoC") > > > > > Is that line incorrect? > > > > > > > > > No, this patch can also fix the problem. > > > > In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in > > > both patches. > > > > > > What is the commit id of the other change you are referring to here? > > > > > This commit id is the bug I'm trying to fix. The Fixes tag need to add it. > > > > Thanks, > > Xingyu Wu > > > I think Greg is looking for this: > > commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019 > > clk: starfive: jh7110-sys: Add notifier for PLL0 clock That commit is already in the following releases: 6.6.51 6.10.10 so what are we supposed to be doing here? confused, greg k-h
