On Sun, Sep 15, 2024 at 12:45:25AM +0530, Vinod Koul wrote: > On 13-09-24, 17:21, Vinod Koul wrote: > > On 11-09-24, 14:31, Greg KH wrote: > > > On Tue, Sep 10, 2024 at 04:02:29PM +0300, Péter Ujfalusi wrote: > > > > Hi, > > > > > > > > On 10/09/2024 15:40, Peter Ujfalusi wrote: > > > > > The prop->src_dpn_prop and prop.sink_dpn_prop is allocated for the _number_ > > > > > of ports and it is forced as 0 index based. > > > > > > > > > > The original code was correct while the change to walk the bits and use > > > > > their position as index into the arrays is not correct. > > > > > > > > > > For exmple we can have the prop.source_ports=0x2, which means we have one > > > > > port, but the prop.src_dpn_prop[1] is accessing outside of the allocated > > > > > memory. > > > > > > > > > > This reverts commit 6fa78e9c41471fe43052cd6feba6eae1b0277ae3. > > > > > > > > I just noticed that Krzysztof already sent the revert patch but it is > > > > not picked up for stable-6.10.y > > > > > > > > https://lore.kernel.org/lkml/20240909164746.136629-1-krzysztof.kozlowski@xxxxxxxxxx/ > > > > > > Is this in Linus's tree yet? That's what we are waiting for. > > > > Yes I was waiting for that as well, the pull request has been sent to > > Linus, this should be in his tree, hopefully tomorow.. > > It is in Linus's tree now. Greg would you like to drop commit > 6fa78e9c41471fe43052cd6feba6eae1b0277ae3 or carry it and the > revert...? I can not "drop" a commit that is already in a realease for obvious reasons :( > What is the usual process for you to handle reverts? We just take them like normal. What is the git id of the revert in Linus's tree? thanks, greg k-h
