On Tue, Dec 03, 2019 at 01:49:03AM +0900, Keith Busch wrote: > Customer or OEM requirments are poorly written, like "Must report NVMe > version 1.3". Nobody bothers to mention that it must also be compliant > to that version, or even realize they never cared for those features in > the first place. > > Compliance testing like from UNH should have caught this before shipping > with such a device, but it's a cheap device, so maybe they skip that step. > > > I wonder if we actually do users a favour by allowing that.. > > I think it's too late now. We did successfully use such namespaces > before 5.4, even if they're fundamentally broken. > > Johannes also commented *not* to consider these errors when this > identification was originally implemented, so either he knew vendors > screwed this up, or had the forethought to know they would. Yes. I guess your patch is the best thing for now: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But I think we might need a new kernel tain flag or something like it for devices that are so obviously broken in their identifiers.
