On 12/2/2019 9:22 AM, Keith Busch wrote:
On Mon, Dec 02, 2019 at 05:15:45PM +0100, Christoph Hellwig wrote:
On Tue, Dec 03, 2019 at 12:56:11AM +0900, Keith Busch wrote:
> Despite NVM Express specification 1.3 requires a controller claiming to
> be 1.3 or higher implement Identify CNS 03h (Namespace Identification
> Descriptor list), the driver doesn't really need this identification in
> order to use a namespace. The code had already documented in comments
> that we're not to consider an error to this command.
>
> Return success if the controller provided any response to an
> namespace identification descriptors command.
>
> Fixes: 538af88ea7d9de24 ("nvme: make nvme_report_ns_ids propagate error back")
> Reported-by: Ingo Brunberg <ingo_brunberg@xxxxxx>
Why would we ignore the error? Do you have a buggy controller messing
this up?
I don't have such a controller, but many apparently do. The regression
was reported here:
http://lists.infradead.org/pipermail/linux-nvme/2019-December/028223.html
And of course it's the SMI controller ...
Does 5.4 show the exact error code? Perhaps we should selectively allow just
for that case?
Ed
