Re: [PATCH] m68k: Add -ffreestanding to CFLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

On Fri, Jan 18, 2019 at 11:11 PM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 18 Jan 2019, Sasha Levin wrote:
> > [This is an automated email]
> >
> > This commit has been processed because it contains a -stable tag.
> > The stable tag indicates that it's relevant for the following trees: all
> >
> > The bot has tested the following trees: v4.20.2, v4.19.15, v4.14.93, v4.9.150, v4.4.170, v3.18.132.
> >
> > v4.20.2: Build OK!
> > v4.19.15: Build OK!
> > v4.14.93: Failed to apply! ...
> > v4.9.150: Failed to apply! ...
> > v4.4.170: Failed to apply! ...
> > v3.18.132: Failed to apply! ...
> >
> > How should we proceed with this patch?
> >
>
> Maybe we should ask Geert to drop the v1 patch?
>
> I think this should work on every branch --
>
> diff --git a/arch/m68k/Makefile b/arch/m68k/Makefile
> index 0b29dcfef69f..0c736ed58abd 100644
> --- a/arch/m68k/Makefile
> +++ b/arch/m68k/Makefile
> @@ -59,7 +59,10 @@ cpuflags-$(CONFIG_M5206e)    := $(call cc-option,-mcpu=5206e,-m5200)
>  cpuflags-$(CONFIG_M5206)       := $(call cc-option,-mcpu=5206,-m5200)
>
>  KBUILD_AFLAGS += $(cpuflags-y)
> -KBUILD_CFLAGS += $(cpuflags-y) -pipe
> +KBUILD_CFLAGS += $(cpuflags-y)
> +
> +KBUILD_CFLAGS += -pipe -ffreestanding
> +
>  ifdef CONFIG_MMU
>  # without -fno-strength-reduce the 53c7xx.c driver fails ;-(
>  KBUILD_CFLAGS += -fno-strength-reduce -ffixed-a2
>
> Shall I send v2?

That's not needed. I replaced your v1, and pushed it to kernel.org branch
test-freestanding for the autobuilders.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux