Hey Greg,
On Tue, Feb 20, 2024 at 10:09:22AM +0100, Greg KH wrote:
> On Tue, Feb 20, 2024 at 09:43:31AM +0100, Uwe Kleine-König wrote:
> > On Tue, Feb 20, 2024 at 08:53:15AM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > > From 036a47643b18d2b0754a86902c1e7e76173fbc3f Mon Sep 17 00:00:00 2001
> > > From: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > Date: Sat, 30 Sep 2023 18:52:04 +0200
> > > Subject: modpost: Don't let "driver"s reference .exit.*
> > >
> > > From: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> > >
> > > commit f177cd0c15fcc7bdbb68d8d1a3166dead95314c8 upstream.
> > >
> > > Drivers must not reference functions marked with __exit as these likely
> > > are not available when the code is built-in.
> > >
> > > There are few creative offenders uncovered for example in ARCH=amd64
> > > allmodconfig builds. So only trigger the section mismatch warning for
> > > W=1 builds.
> > >
> > > The dual rule that drivers must not reference .init.* is implemented
> > > since commit 0db252452378 ("modpost: don't allow *driver to reference
> > > .init.*") which however missed that .exit.* should be handled in the
> > > same way.
> > >
> > > Thanks to Masahiro Yamada and Arnd Bergmann who gave valuable hints to
> > > find this improvement.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >
> > Otherwise I'm not sure about the benefit of backporting this patch. It
> > only introduces more warnings (for W=1 builds) but doesn't fix anything.
>
> Needed for a follow-on patch.
For some time you had that information added to the S-o-b area. I found
that super useful.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
