This is a note to let you know that I've just added the patch titled
usb: typec: tpcm: Fix issues with power being removed during reset
to the 6.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-typec-tpcm-fix-issues-with-power-being-removed-during-reset.patch
and it can be found in the queue-6.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 69f89168b310878be82d7d97bc0d22068ad858c0 Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@xxxxxxxxxx>
Date: Mon, 12 Feb 2024 18:42:13 +0000
Subject: usb: typec: tpcm: Fix issues with power being removed during reset
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Mark Brown <broonie@xxxxxxxxxx>
commit 69f89168b310878be82d7d97bc0d22068ad858c0 upstream.
Since the merge of b717dfbf73e8 ("Revert "usb: typec: tcpm: fix
cc role at port reset"") into mainline the LibreTech Renegade
Elite/Firefly has died during boot, the main symptom observed in testing
is a sudden stop in console output. Gábor Stefanik identified in review
that the patch would cause power to be removed from devices without
batteries (like this board), observing that while the patch is correct
according to the spec this appears to be an oversight in the spec.
Given that the change makes previously working systems unusable let's
revert it, there was some discussion of identifying systems that have
alternative power and implementing the standards conforming behaviour in
only that case.
Fixes: b717dfbf73e8 ("Revert "usb: typec: tcpm: fix cc role at port reset"")
Cc: stable <stable@xxxxxxxxxx>
Cc: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20240212-usb-fix-renegade-v1-1-22c43c88d635@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/typec/tcpm/tcpm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -4862,7 +4862,8 @@ static void run_state_machine(struct tcp
break;
case PORT_RESET:
tcpm_reset_port(port);
- tcpm_set_cc(port, TYPEC_CC_OPEN);
+ tcpm_set_cc(port, tcpm_default_state(port) == SNK_UNATTACHED ?
+ TYPEC_CC_RD : tcpm_rp_cc(port));
tcpm_set_state(port, PORT_RESET_WAIT_OFF,
PD_T_ERROR_RECOVERY);
break;
Patches currently in stable-queue which might be from broonie@xxxxxxxxxx are
queue-6.7/asoc-intel-avs-fix-dynamic-port-assignment-when-tdm-.patch
queue-6.7/asoc-intel-avs-fix-pci_probe-error-path.patch
queue-6.7/usb-typec-tpcm-fix-issues-with-power-being-removed-during-reset.patch
queue-6.7/asoc-amd-yc-add-dmi-quirk-for-lenovo-ideapad-pro-5-16arp8.patch
queue-6.7/asoc-sof-ipc3-topology-fix-pipeline-tear-down-logic.patch
queue-6.7/asoc-codecs-wcd938x-handle-deferred-probe.patch
queue-6.7/arm64-signal-don-t-assume-that-tif_sve-means-we-saved-sve-state.patch
queue-6.7/asoc-sof-ipc3-fix-message-bounds-on-ipc-ops.patch
queue-6.7/spi-omap2-mcspi-revert-fifo-support-without-dma.patch
queue-6.7/spi-ppc4xx-drop-write-only-variable.patch
queue-6.7/spi-imx-fix-the-burst-length-at-dma-mode-and-cpu-mod.patch
queue-6.7/asoc-amd-yc-add-dmi-quirk-for-msi-bravo-15-c7vf.patch
queue-6.7/asoc-rt5645-fix-deadlock-in-rt5645_jack_detect_work.patch
queue-6.7/kselftest-dt-stop-relying-on-dirname-to-improve-perf.patch
queue-6.7/asoc-tas2781-add-module-parameter-to-tascodec_init.patch
