Re: Patch "modpost: Don't let "driver"s reference .exit.*" has been added to the 6.1-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Greg,

On Tue, Feb 20, 2024 at 08:53:15AM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     modpost: Don't let "driver"s reference .exit.*
> 
> to the 6.1-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      modpost-don-t-let-driver-s-reference-.exit.patch
> and it can be found in the queue-6.1 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> From 036a47643b18d2b0754a86902c1e7e76173fbc3f Mon Sep 17 00:00:00 2001
> From: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> Date: Sat, 30 Sep 2023 18:52:04 +0200
> Subject: modpost: Don't let "driver"s reference .exit.*
> 
> From: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> commit f177cd0c15fcc7bdbb68d8d1a3166dead95314c8 upstream.
> 
> Drivers must not reference functions marked with __exit as these likely
> are not available when the code is built-in.
> 
> There are few creative offenders uncovered for example in ARCH=amd64
> allmodconfig builds. So only trigger the section mismatch warning for
> W=1 builds.
> 
> The dual rule that drivers must not reference .init.* is implemented
> since commit 0db252452378 ("modpost: don't allow *driver to reference
> .init.*") which however missed that .exit.* should be handled in the
> same way.
> 
> Thanks to Masahiro Yamada and Arnd Bergmann who gave valuable hints to
> find this improvement.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
                             ^^
This looks broken ------------' (To maybe help debugging: This is an
utf-8 ö interpreted as latin1:

	$ echo König | iconv -t utf-8 | iconv -f latin1
	König

)

Otherwise I'm not sure about the benefit of backporting this patch. It
only introduces more warnings (for W=1 builds) but doesn't fix anything.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux