Hi, this should be the last patch to avoid any compilation issues On Tue, 2016-10-18 at 19:46 +0200, Francois Gouget wrote: > For Spice-gtk most deprecation issues come from changes outside > Spice > (GLib) and thus should not be treated as errors to not break > compilation for users who have newer third-party libraries. > However they must be visible otherwise Spice developers will not be > aware of them and thus will not fix them before breakage happens. > > Signed-off-by: Francois Gouget <fgouget@xxxxxxxxxxxxxxx> > --- > m4/spice-compile-warnings.m4 | 2 +- > src/controller/Makefile.am | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile- > warnings.m4 > index 533bac6..dfa88fe 100644 > --- a/m4/spice-compile-warnings.m4 > +++ b/m4/spice-compile-warnings.m4 > @@ -85,7 +85,7 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[ > gl_WARN_ADD([-Wno-format-nonliteral]) > # We use some deprecated functions to avoid #ifdef hell while > maintaining > # compat with older gtk / glib versions > - gl_WARN_ADD([-Wno-deprecated-declarations]) > + gl_WARN_ADD([-Wno-error=deprecated-declarations]) > > > > diff --git a/src/controller/Makefile.am b/src/controller/Makefile.am > index fb56986..00552e8 100644 > --- a/src/controller/Makefile.am > +++ b/src/controller/Makefile.am > @@ -4,7 +4,6 @@ AM_CPPFLAGS = > \ > -DG_LOG_DOMAIN=\"GSpiceController\" \ > $(GIO_CFLAGS) \ > $(COMMON_CFLAGS) \ > - -Wno-deprecated-declarations \ we should keep it, because we don't have much control over the generated C code by vala Pavel > $(NULL) > > # http://www.gnu.org/software/libtool/manual/html_node/Updating-ver > sion-info.html _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel