On Fri, 2016-10-14 at 12:08 +0200, Francois Gouget wrote: > On Fri, 14 Oct 2016, Frediano Ziglio wrote: > [...] > > > typedef struct RedChannel RedChannel; > > > typedef struct RedClient RedClient; > > > -typedef struct IncomingHandler IncomingHandler; > > > > > > typedef struct RedChannelClient RedChannelClient; > > > typedef struct RedChannelClientClass RedChannelClientClass; > > > > For me > > > > Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > > > However I'll wait to understand if others prefer to > > remove the typedef from the structure declaration... > > but both would work, just style preferences. > > I chose that approach to match OutgoingHandler. It is matter of preferences, I also prefer this way but for instance in virt-viewer or spice-gtk is common to have it the other way (no typedef at struct). Maybe it is common for glib based projects ? Pavel > > RedChannelClient is a bit different in that the typedef is already > defined in two places: red-channel.h and red-channel-client.h (this > also causes compilation errors on RHEL 6.8 btw). > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel