On Fri, 14 Oct 2016, Frediano Ziglio wrote: [...] > > typedef struct RedChannel RedChannel; > > typedef struct RedClient RedClient; > > -typedef struct IncomingHandler IncomingHandler; > > > > typedef struct RedChannelClient RedChannelClient; > > typedef struct RedChannelClientClass RedChannelClientClass; > > For me > > Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > However I'll wait to understand if others prefer to > remove the typedef from the structure declaration... > but both would work, just style preferences. I chose that approach to match OutgoingHandler. RedChannelClient is a bit different in that the typedef is already defined in two places: red-channel.h and red-channel-client.h (this also causes compilation errors on RHEL 6.8 btw). -- Francois Gouget <fgouget@xxxxxxxxxxxxxxx> _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel