On Mon, 2015-10-26 at 10:47 +0100, Christophe Fergeau wrote: > Hey, > > Is this still happening with latest git? I'm fairly sure I fixed > these > warnings a while ago, and that adding subdir-objects was not really > needed. Hmm, this actually happened when I attempted to rebuild a rhel6 package on fedora 22. In other words, I was basically trying to run autoreconf on a tarball release.. So I guess I'm not totally sure whether it's necessary in git or not... > > On Fri, Oct 23, 2015 at 02:59:32PM -0500, Jonathon Jongsma wrote: > > Without this, newer versions of automake give a warning, and since > > -Werror is set, this is treated as an error. This can result in > > build > > failures such as: > > > > automake: warnings are treated as errors > > common/Makefile.am:4: warning: source file > > '$(srcdir)/generated_client_demarshallers.c' is in a subdirectory, > > common/Makefile.am:4: but option 'subdir-objects' is disabled > > automake: warning: possible forward-incompatibility. > > automake: At least a source file is in a subdirectory, but the > > 'subdir-objects' > > automake: automake option hasn't been enabled. For now, the > > corresponding output > > automake: object file(s) will be placed in the top-level directory. > > However, > > automake: this behaviour will change in future Automake versions: > > they will > > automake: unconditionally cause object files to be placed in the > > same subdirectory > > automake: of the corresponding sources. > > automake: You are advised to start using 'subdir-objects' option > > throughout your > > automake: project, to avoid future incompatibilities. > > common/Makefile.am:4: warning: source file > > '$(srcdir)/generated_client_demarshallers1.c' is in a subdirectory, > > common/Makefile.am:4: but option 'subdir-objects' is disabled > > common/Makefile.am:4: warning: source file > > '$(srcdir)/generated_client_marshallers.c' is in a subdirectory, > > common/Makefile.am:4: but option 'subdir-objects' is disabled > > common/Makefile.am:4: warning: source file > > '$(srcdir)/generated_client_marshallers1.c' is in a subdirectory, > > common/Makefile.am:4: but option 'subdir-objects' is disabled > > common/Makefile.am:11: warning: source file > > '$(srcdir)/generated_server_demarshallers.c' is in a subdirectory, > > common/Makefile.am:11: but option 'subdir-objects' is disabled > > common/Makefile.am:11: warning: source file > > '$(srcdir)/generated_server_marshallers.c' is in a subdirectory, > > common/Makefile.am:11: but option 'subdir-objects' is disabled > > This is no longer accurate, $(srcdir) was removed in > http://cgit.freedesktop.org/spice/spice-common/commit/common/Makefile > .am?id=7ea1cc54b1cdc105e086c154cc15b2541937c7b7 > > NACK until you provide more details about the exact issue. > > Christophe _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel